search

phetsims / inverse-square-law-common

GNU General Public License v3.0
1 stars 2 forks source link

Disable Scientific Notation when Force Values off #51

Closed arouinfar closed 6 years ago

arouinfar commented 6 years ago

In https://github.com/phetsims/coulombs-law/issues/47 we considered indenting the Scientific Notation checkbox since it has child/parent relationship with Force Values, but ultimately decided against it.

However, we did not consider the case of simply disabling/graying out the Scientific Notation checkbox when Force Values is off. This was something that came up in yesterday's meeting to discuss the static descriptions for Coulomb's Law, and again this morning when meeting with @terracoda.

The static descriptions would be a bit clearer, because the screen reader would indicate that the checkbox is disabled. I think this is also better UX for all users.

image

What do you think @ariel-phet?

ariel-phet commented 6 years ago

@arouinfar that change works for me

arouinfar commented 6 years ago

Thanks @ariel-phet!

@mbarlow12 can you please make this change?

mbarlow12 commented 6 years ago

Will do! @arouinfar will this apply to GFL as well?

arouinfar commented 6 years ago

Great question @mbarlow12! Yes, this change would apply to GFL, as well.

arouinfar commented 6 years ago

@mbarlow12 after you make this change, can you publish a new dev version of Coulomb's Law?

mbarlow12 commented 6 years ago

New dev depolyment:

https://phet-dev.colorado.edu/html/coulombs-law/1.0.0-dev.17/phet/coulombs-law_en_phet.html

arouinfar commented 6 years ago

Thanks @mbarlow12. CL and GFL are looking good!