phetsims / inverse-square-law-common

GNU General Public License v3.0
1 stars 2 forks source link

no need to replace {{value}} with {0} #59

Closed pixelzoom closed 5 years ago

pixelzoom commented 5 years ago

See https://github.com/phetsims/scenery-phet/issues/446#issuecomment-460726349

NumberControl and NumberDisplay now support both '{{value}}' and '{0}'. So...

In ISLCObjectControlPanel.js, this:

90 valuePattern: StringUtils.fillIn( pattern0Value1UnitsString, { value: '{0}', units: unitString } ),

can be changed to this:

90 valuePattern: StringUtils.fillIn( pattern0Value1UnitsString, { units: unitString } ),

jessegreenberg commented 5 years ago

Thanks, done above.