Audit all strings before new publication

phetsims / inverse-square-law-common

GNU General Public License v3.0

1 stars 2 forks source link

Audit all strings before new publication #75

Closed zepumph closed 5 years ago

zepumph commented 5 years ago

From https://github.com/phetsims/inverse-square-law-common/issues/26, it would be good to make sure that all strings are in tip top shape before next publications of GFLB and then later GFL.

zepumph commented 5 years ago

[x] I see that in CL there is a duplicated string with a different key from the GFL sims:
In CL: moveInSmallerStepsLabel, in GFL moveInSmallerSteps (and same with largerSteps)

I'm not sure if these should be consolidated. It is duplication, and probably belongs in scenery-phet, though it is only used in ISLC sims. It may also be alright though, because these are for individual keyboard help dialogs.

UPDATE: after discussing with @jbphet, we feel like there isn't any value in moving/updating these. They are fine to be left alone.

zepumph commented 5 years ago

[x] constantSize is in ISLC but only used by GFL and GFLB
[x] mass is in ISLC but only used by GFLB
[x] units.meter is in ISLC but only used by PositionDescriber. Should it be an a11y string? UPDATE: even though it is just an a11y string, I'm going to keep it.
- [x] units.meters is in ISLC and only used by PositionDescriber (so as a11y string) and GFLB (as view string) UPDATE: after talking with @jbphet I'm just going to keep it here.
[x] units.newtons is only used in describers. UPDATE: it makes some sense to keep it here next to other units. So I'll do that.

Some of these strings I'm unsure how to handle. I will take a best guess.

zepumph commented 5 years ago

Alright, I made changes above that made sense to me. There were a few places where I elected to keep things as is, because it seemed more like an orthogonal change that could just be reverted in the future, like when CL get's descriptions.