phetsims / isotopes-and-atomic-mass

"Isotopes And Atomic Mass" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
3 stars 3 forks source link

MonoIsotopeBucket takes too many parameters #69

Closed andrewadare closed 8 years ago

andrewadare commented 8 years ago

Currently, it takes 7 (8 with a future Tandem instance).

This is a design/maintenance liability because of JavaScript's lack of runtime parameter checking.

Ideally, it should be closer to 4 or 5. Please check if there is a straightforward way to reduce the number of parameters without making other design compromises (perhaps use default options, pass in a larger object, or some other strategy).

(#57)

andrewadare commented 8 years ago

Looks great, thanks.