search

phetsims / isotopes-and-atomic-mass

"Isotopes And Atomic Mass" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
3 stars 3 forks source link

Missing calls to `unlink` #70

Closed andrewadare closed 8 years ago

andrewadare commented 8 years ago

There are 19 occurrences of link and 4 occurrences of lazyLink, but currently only one unlink call in the whole sim.

According to the CRC, the unlink functions should be called in the appropriate places, or explanations of why they are omitted should be provided.

(#57)

andrewadare commented 8 years ago

Looks like shred contains lots of useful examples for guidance on how/where to pair the unlink functions with the links.

andrewadare commented 8 years ago

I now see either unlink calls or docs explaining their absence. Looks good; closing.