Accordion box slightly off screen

phetsims / isotopes-and-atomic-mass

"Isotopes And Atomic Mass" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

3 stars 3 forks source link

Accordion box slightly off screen #96

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

Minor design bug found in https://github.com/phetsims/QA/issues/310, but present in published version. When string are longer than normal (double and long) the yellow accordion boxes on the mixture screen go slightly out of bounds. The +/- boxes are always visible and clickable, but it can look odd. To see this, use either an iPad/iPhone or the dev parameter. boxoffedge Image from iOS

arouinfar commented 5 years ago

Nice find @KatieWoe. It seems like the accordion menus don't have an appropriate maxWidth @jbphet. Since they are already quite wide, I don't think they need to expand any further for i18n.

Not sure if it's relevant here, but according to https://github.com/phetsims/joist/issues/542#issuecomment-443920171 this sim uses non-standard layoutBounds.

jbphet commented 5 years ago

I've added maxWidth params for these accordion boxes.

jbphet commented 5 years ago

Fixed and deployed. Closing.