search

phetsims / isotopes-and-atomic-mass

"Isotopes And Atomic Mass" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
3 stars 3 forks source link

TypeError: Class constructor cannot be invoked without 'new' #99

Closed samreid closed 4 years ago

samreid commented 4 years ago

In https://github.com/phetsims/tasks/issues/1044, Particle.js was converted to class but js/mix-isotopes/model/MovableAtom.js extends it using inherit which causes this error on CT:

TypeError: Class constructor cannot be invoked without 'new'

I don't see any other subtypes of MovableAtom--I'll try converting it to a class to see if it helps.

samreid commented 4 years ago

Proposed fix committed, reassigning to the responsible dev for review & testing.

pixelzoom commented 4 years ago

Thanks for taking care of that, sorry I missed the MovableAtom subclass.

jbphet commented 4 years ago

Thanks for the fix @samreid. Closing.