search

phetsims / john-travoltage

"John Travoltage" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/john-travoltage
GNU General Public License v3.0
4 stars 8 forks source link

Voicing sim does not load on app #418

Closed KatieWoe closed 3 years ago

KatieWoe commented 3 years ago

I did a quick check on 1.6.0-preferences.7 on the android app (Galaxy Tab A) and the sim did not load in the app.

KatieWoe commented 3 years ago

I'm having trouble getting the right version of the app on the chromebook for some reason, in order to test it there. @mattpen if you are able to help out I would appreciate it.

KatieWoe commented 3 years ago

Thanks for the help Matt. This is also impacting the sim on the app on Chromebook.

jessegreenberg commented 3 years ago

Thanks @KatieWoe, I think I have a better way to handle this. Can you please test with this version?

https://phet-dev.colorado.edu/html/john-travoltage/1.6.0-preferences.13/phet/john-travoltage_en_phet.html

I expect the sim to load in the app, but the Voicing feature should be disabled in this case (not in available from Preferences).

KatieWoe commented 3 years ago

Sim ran on the app on the tablet. Voicing didn't work, but the tab was still available, it just didn't do anything when on

jessegreenberg commented 3 years ago

Thanks @KatieWoe, glad its running. Sorry I mispoke, the tab should be available, but the Voicing section should not be. It should look like this: image

Can you please confirm?

KatieWoe commented 3 years ago

That is not what it looks like. It looks like the other versions, with all the voicing options. But turning it on does nothing.

jessegreenberg commented 3 years ago

Thanks! That is not working as I would expect, I will take a look at that.

jessegreenberg commented 3 years ago

I am not too sure how to debug the sim in the app, but I am going to try to tether my phone running the App to my desktop and see if desktop Chrome can pick up the WebView running in the app.

jessegreenberg commented 3 years ago

When I did this, I saw that the window.SpeechSynthesis was not defined in the webview, which is what I would expect. Maybe something is wrong with the drawing code for the tabs.

jessegreenberg commented 3 years ago

I think this is fixed, @KatieWoe can you please check to verify that Voicing is not available on this platform, and nothing about it shows up in the Preferences Dialog?

https://phet-dev.colorado.edu/html/john-travoltage/1.6.0-preferences.16/phet/john-travoltage_en_phet.html

KatieWoe commented 3 years ago

This looks mostly ok on both the tablet and the Chromebook. I did notice that on one tab text was centered, and on another it was left justified. Image from iOS (1) Image from iOS

jessegreenberg commented 3 years ago

Thanks @KatieWoe, layout fixed in the above commit. I think that is it for this issue since it was verified to load correctly from the webview.