search

phetsims / john-travoltage

"John Travoltage" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/john-travoltage
GNU General Public License v3.0
4 stars 8 forks source link

Create subclasses for the Arm and Leg Nodes in this sim #420

Closed jessegreenberg closed 3 years ago

jessegreenberg commented 3 years ago

Both are implemented with AppendageNode, and while they share a lot of code there are many checks that determine if the model is an instance of Leg or Arm.

This was recommended during review of the Voicing implementation. But there are other features (description, dragging behavior) that have arm/leg checks.

jessegreenberg commented 3 years ago

From https://github.com/phetsims/scenery/issues/1223

jessegreenberg commented 3 years ago

I created new subclasses of AppendageNode for this issue and it was a really nice improvement in several areas. Closing.