search

phetsims / john-travoltage

"John Travoltage" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/john-travoltage
GNU General Public License v3.0
4 stars 8 forks source link

Don't always hear "just above" and "just below" door knob during interaction #421

Closed terracoda closed 3 years ago

terracoda commented 3 years ago

Using https://phet-dev.colorado.edu/html/john-travoltage/1.6.0-preferences.6/phet/john-travoltage_en_phet.html

on MacOS 10.13.6

I am not always hearing the "just above" and "just below" locations.

Not sure why. It might be an artifact of the original interactive description's aria-value text implementation.

I hear the correct position on focus. Just sometimes as I pass the doorknob, I don't hear the first position above or below when passing.

jessegreenberg commented 3 years ago

Thanks @terracoda, fixed in the above commit. caused by a silly mistake of mine. Can you please verify it is fixed in https://phet-dev.colorado.edu/html/john-travoltage/1.6.0-preferences.9/phet/john-travoltage_en_phet.html?

terracoda commented 3 years ago

Hmm, I though I already verified this issue last week. It sounds good. Thanks @jessegreenberg, closing.