search

phetsims / john-travoltage

"John Travoltage" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/john-travoltage
GNU General Public License v3.0
4 stars 8 forks source link

Update screenshots #426

Closed arouinfar closed 3 years ago

arouinfar commented 3 years ago

While reviewing the updated sim pages on ox-dev, I noticed that the alternate screenshot is identical to the main screenshot. The screenshots currently checked in are indeed identical, but the alt used to look like this:

image

arouinfar commented 3 years ago

I ended up updating both screenshots using the latest dev version on the preferences branch so the navbar icons would all be present.

There's no urgent need to update the sim screenshots on the website, so this change can wait until the next redeploy from master.

I don't think there's anything to cherry-pick here since there'll probably be a new release branch created when the sim redeploys, but assigning @jessegreenberg to confirm.

jessegreenberg commented 3 years ago

I don't think there's anything to cherry-pick here since there'll probably be a new release branch created when the sim redeploys, but assigning @jessegreenberg to confirm.

Yes, we will be republishing this sim again off of master. -Would you like to keep this open or OK to close?

arouinfar commented 3 years ago

Let's close @jessegreenberg