phetsims / john-travoltage

"John Travoltage" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/john-travoltage
GNU General Public License v3.0
4 stars 8 forks source link

Keyboard Shortcuts dialog - updates for new Move Hand direction #428

Closed terracoda closed 3 years ago

terracoda commented 3 years ago

In issue #425 we reversed the direction of the Arm Swing interaction to better align with swipes when using iOS VoiceOver and to be the same direction as the Leg Swing interaction.

We felt this change required changes to how we describe these interactions in the Keyboard Shortcuts dialog. We decided to explicitly describe the preferred directions using the Arrow keys, though all directions work just fine because these are slider interactions. All four arrow keys work by default to augment and decrement sliders.

The Interactive Description Design Document has been updated with the following information. Screen Shot 2021-07-13 at 4 16 57 PM

In the Accessible Content these interactions are as follows: H2: Hand or Foot UL: LI: Move foot with Left and Right Arrow keys. LI: Move hand with Up and Down Arrow keys.

The heading, Tab to get started, and Basic Actions are all part of common code.

jessegreenberg commented 3 years ago

Updates made, @terracoda can you please review in this version?

https://phet-dev.colorado.edu/html/john-travoltage/1.6.0-dev.44/phet/john-travoltage_en_phet.html

terracoda commented 3 years ago

Looks and sounds awesome! Thanks.