search

phetsims / john-travoltage

"John Travoltage" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/john-travoltage
GNU General Public License v3.0
4 stars 8 forks source link

"Samantha" listed twice in the combo box #436

Closed Nancy-Salpepi closed 3 years ago

Nancy-Salpepi commented 3 years ago

Test device MacBook Air M1chip

Operating System 11.4 Browser Safari 14.1.1

Problem description https://github.com/phetsims/qa/issues/676

In audio preferences, the name "Samantha" appears twice in the combo box.

Steps to reproduce

  1. Click on the preferences icon in the toolbar panel
  2. Navigate to audio preferences
  3. Enable voicing by moving the toggle button
  4. Expand the customize voice panel

Visuals

Screen Shot 2021-07-27 at 1 55 49 PM

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪John Travoltage‬ URL: https://phet-dev.colorado.edu/html/john-travoltage/1.6.0-rc.1/phet/john-travoltage_all_phet.html Version: 1.6.0-rc.1 2021-07-22 18:05:38 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.1 Safari/605.1.15 Language: en-us Window: 1352x683 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 8192x8192 OES_texture_float: true Dependencies JSON: {}

jessegreenberg commented 3 years ago

Thanks @Nancy-Salpepi. Safari on my macOS 11.4 only has Samantha listed once. The voices in the ComboBox are provided by the browser/operating system. Can you please comment on whether the two "Samantha's" sound different? If they really are a duplicate, we probably want to prune the list. If they sound different, maybe we want to rename the second one? Im not sure.

Nancy-Salpepi commented 3 years ago

The first Samantha option does not work. The name isn't said aloud when I choose it and no voicing occurs with it.

jessegreenberg commented 3 years ago

Oh wow - ok understood. Ideally the broken one would be removed. But I don't know how we can distinguish the broken one from the working one.

jessegreenberg commented 3 years ago

@Nancy-Salpepi mentioned the duplication was only in Safari.

Nancy-Salpepi commented 3 years ago

To be more specific--it wasn't on chrome. I have only looked at those 2 browsers so far.

jessegreenberg commented 3 years ago

@Nancy-Salpepi can you please test this now? I made it so that any voices of the same name will be removed from the list. Hopefully removing the duplicate will make it so the one that remains works.

The fix was in joist, so to test go to phettest and pull joist, then run john-travoltage again from master.

Nancy-Salpepi commented 3 years ago

There is only one Samantha now listed, but that one doesn't work. Originally the first Samantha didn't work but the second one did. My guess is that by @jessegreenberg removing the duplicate--it was the second (functioning) one that was omitted.

jessegreenberg commented 3 years ago

I am not sure if there is anythign we can do about this. But I think it would be helpful to meet briefly and inspect the voices on @Nancy-Salpepi's machine to see if the broken "Samantha" has anything about it that would let us prune it from the list. We scheduled a time tomorrow to take a look.

jessegreenberg commented 3 years ago

@Nancy-Salpepi and I took a look this morning and noticed that the "Samantha" voices had the same name but a different voiceURI property.

Screen Shot 2021-07-28 at 9 10 15 AM

The "broken" voice had "premium" as part of the URI. I am going to try to remove voices with that in the URI for now. I don't really like this fix because I don't have confidence that it will be broken for all platforms.

@Nancy-Salpepi can you please verify that this was fixed in master by pulling joist and testing on phettest?

Nancy-Salpepi commented 3 years ago

Now in the combo box, Samantha is the ONLY voice listed

Screen Shot 2021-07-28 at 11 44 20 AM
jessegreenberg commented 3 years ago

I see, thanks @Nancy-Salpepi - so that confirms the case that we cannot remove all "premium" voices. Many (most) with "premium" in the URI work fine.

I would like to discuss this with @emily-phet and @terracoda.

jessegreenberg commented 3 years ago

Discussed with @emily-phet and @terracoda:

This problem is outside of PhET's control and we will not spend more time trying to find a workaround. We will do a quick check to see if we can find a fix on the machine where this happened so we are prepared to help users if this comes up in the wild, but otherwise we will let this go.

KatieWoe commented 3 years ago

On iPadOS 14.7.1, Samantha seems to be the only available option. Should the combo box still be in place with a case like this?

jessegreenberg commented 3 years ago

https://github.com/phetsims/joist/commit/0ec5b29dfca412d79ccee73605aea58736d63010 and https://github.com/phetsims/joist/commit/b18a3085fa5fdc3d782156455e1a3efb9fd875f0 need to be reverted in master.

Regarding https://github.com/phetsims/john-travoltage/issues/436#issuecomment-890080426

Good question @KatieWoe. I suspect this is OK, but its a good design question. @terracoda @emily-phet would you like to change the UI when there is only one voice available?

emily-phet commented 3 years ago

I think it's fine to leave this as-is - combobox interface even if only 1 voice in place. All of our general supporting materials for voicing and preferences menu will indicate that this is a combobox, and will also make clear that the list is the list of voices available on your current device. I think with that support, many people will recognize they only have one option because their device has only one option to populate it with.

jessegreenberg commented 3 years ago

OK, thanks @emily-phet, closing.

jessegreenberg commented 3 years ago

These changes have been reverted in the above comits.

Nancy-Salpepi commented 3 years ago

@jessegreenberg I started to do the spot check on safari and there is only 1 Samantha voice listed now, but that one does not work. Samantha voice also doesn't work on Mac + chrome

KatieWoe commented 3 years ago

Linking to https://github.com/phetsims/qa/issues/697

terracoda commented 3 years ago

I am un-assigning myself from this issue.

jessegreenberg commented 3 years ago

Unfortunately there is nothing we can do on the sim side to fix this voice or remove this voice. In https://github.com/phetsims/john-travoltage/issues/436#issuecomment-889409141 we agreed to continue publishing with this issue.

jessegreenberg commented 3 years ago

@Nancy-Salpepi and I just paired on the machine where this is broken. We found that by going to system voices and deleting "Samantha" then re-downloading "Samantha" fixed this problem for her machine. Unfortunate that we cannot fix this in the sim, but this gives us something to recommend if we get reports of this in the wild.

jessegreenberg commented 3 years ago

Closing this again.