search

phetsims / john-travoltage

"John Travoltage" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/john-travoltage
GNU General Public License v3.0
4 stars 8 forks source link

Sim won't open on Android app #443

Closed KatieWoe closed 3 years ago

KatieWoe commented 3 years ago

For https://github.com/phetsims/qa/issues/676. Seen on Galaxy Tab A Android 8.1. In the app, when trying to open the sim, it gets to the phet logo but the loading bar never starts to fill and the sim never loads.

jessegreenberg commented 3 years ago

Thanks @KatieWoe, it definitely should, especially after https://github.com/phetsims/john-travoltage/issues/418.

Are you able to see any errors in a console or anything like that?

KatieWoe commented 3 years ago

I don't know how to look at the console of the app on that device.

jessegreenberg commented 3 years ago

OK, understood. I think the problem is that the audioManager is trying to initialize speech synthesis regardless of whether it is enabled. It used to be that speech synthesis was only initialized if requested from PreferencesConfiguration (which took locale and speech synth available into account).

jessegreenberg commented 3 years ago

@KatieWoe can you please see if this is fixed in the app in https://phet-dev.colorado.edu/html/john-travoltage/1.7.0-dev.1/phet/john-travoltage_en_phet.html?

KatieWoe commented 3 years ago

That dev version loads up in the app

jessegreenberg commented 3 years ago

Excellent, thanks @KatieWoe, will move the change to the release branch.

jessegreenberg commented 3 years ago

Cherry pick done above.

KatieWoe commented 3 years ago

1.6.0-rc.2 is not loading on the android app Edit: Link https://github.com/phetsims/qa/issues/693

jessegreenberg commented 3 years ago

Darn, the SHA was updated but not dependencies.json. RC joist sha is a515f, here is log for john-travoltage-1.6 branch of joist image

Needs to bump upto 35ba7

jessegreenberg commented 3 years ago

dependencies.json updated in the above commit, ready again for another spot check to make sure this made it to the build for release.

KatieWoe commented 3 years ago

The app now opens. However, on both the tablet and chromebook, there is no voicing option, even if it is there in the browser on the same device.

jessegreenberg commented 3 years ago

Thanks @KatieWoe - That is what we would expect. SpeechSynthesis is not supported in an Android WebView so it will not work in the App, though it should work in a native browser on the same devices. This change removes Voicing from the sims where SpeechSynthesis is not suppoted but ensures that the sim will still run.

Closing.