Wrong object is sometimes highlighted using keyboard nav

[Nancy-Salpepi]

Test device Mac11 (m1 chip)

Operating System 11.4

Browser safari

Problem description https://github.com/phetsims/qa/issues/697

This issue only occurs sometimes: with interactive highlights and voicing on, when I open and close the toolbar using keyboard nav, the highlight moves off of the button. I have seen it switch to the leg (as seen in video) and I have seen it switch to the overview play button.

Steps to reproduce I have not been able to come up with a set of steps to reliably reproduce.

Visuals https://drive.google.com/file/d/1FmAggQgpkytIOVja-tXkY3-1kIrpgFft/view?usp=sharing

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪John Travoltage‬ URL: https://phet-dev.colorado.edu/html/john-travoltage/1.6.0-rc.3/phet/john-travoltage_en_phet.html Version: 1.6.0-rc.3 2021-08-17 21:42:38 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.1 Safari/605.1.15 Language: en-us Window: 1440x683 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 8192x8192 OES_texture_float: true Dependencies JSON: {}

[Nancy-Salpepi]

Issue also occurs with voicing turned off.

https://drive.google.com/file/d/1HmciR-fy2dP1XrkdBIcNPyogda6B7Wdm/view?usp=sharing

[Nancy-Salpepi]

Upon closer inspection--it seems to be the same issue as

https://github.com/phetsims/balloons-and-static-electricity/issues/523

where the mouse pointer interferes

[jessegreenberg]

Thanks @Nancy-Salpepi - I think you are correct that it is the same as https://github.com/phetsims/balloons-and-static-electricity/issues/523. This should no longer happen in master but this improvement was not added to the SHAs for john-travoltage release. @emily-phet or @terracoda can you please comment on if you would like this fix in john-travoltage? Doing so would require another RC spot check

[Nancy-Salpepi]

Definitely the same issue--it does not occur in master

[jessegreenberg]

Great, thanks for confirming @Nancy-Salpepi.

[terracoda]

In https://github.com/phetsims/balloons-and-static-electricity/issues/523#issuecomment-897034345 we have made a fix for this, but we will not apply this fix for this publication. The issue is less dramatic in this sim since there are no dashed grabbed highlights on any interactions in this sim.

In addition, the issue is an edge case requiring a user to have actively chosen "Interactive Highlights", and to use a mixed input method (both Keyboard and mouse), and to leave their mouse pointer on an interactive element when they switch to using the keyboard. While this is obviously not impossible, we feel it is rare enough that it shouldn't disrupt the user experience too much.

We will include this fix in the next maintenance release or re-publication for this sim.

[terracoda]

Un-assigning myself. @jessegreenberg please re-assign if there is something for me to verify. I can't actually load JT from phettest right now, so I would need the latest dev link to very any design changes or behaviour changes.

[terracoda]

Looks like this is just waiting to deploy :-) not waiting for verification. Apologies for my last comment.