search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
http://scenerystack.org/
MIT License
8 stars 6 forks source link

Adding sim to reading list is inconsistent across iOS versions, can cause problems in iOS 9 #510

Open ghost opened 6 years ago

ghost commented 6 years ago

The purpose of this issue is to document the behaviors for adding a simulation to the iOS Reading List.

Related to phetsims/masses-and-springs/issues/301 and phetsims/joist/issues/502.

iOS 9.3.5

  1. In https://github.com/phetsims/joist/issues/382 and https://github.com/phetsims/joist/issues/470 we determined that "Save to Reading List" automatically saves a "snapshot" of the current DOM which is not automatically cleared when the page is loaded from the reading list. That is most likely what is causing the duplicate rendering and interference.

Duplicate Rendering and Interference: hello

  1. Some simulations will have numbers in their "preview text". thing We know about this; we're not going to fix it. Our working theory (thanks to @jessegreenberg and @samreid) is that iOS is scraping the DOM to generate the preview text. Heartbeat.js adds a div to the document that looks like this <div>0.32540102738293863</div>. When a11y is enabled the PDOM comes before the heartbeat div in the document, which is probably why there are no numbers for RIAW.

  2. It is possible that the Reading List menu will not disappear when something on the Reading List is "clicked." If this is the case, close the Reading List menu manually. Safari should remember that you want the Reading List menu closed, and now when you "click" on something in the Reading List, the Reading List should close automatically.

  3. It is possible for the splash screen to be off-center. I'm guessing this is related to 1. This is rare, and I haven't found a reliable way to reproduce it.

iOS 11.4.1

  1. In iOS 11.4.1, the numbers in the preview text (see 2) are not present because there is no preview text: dog

Both

  1. The Reading List has a feature where the title of what you're "reading" is present. So far as I know this only occurs when WiFi is on. cat

Mentioning @KatieWoe, so she is aware of this issue.

ariel-phet commented 6 years ago

Marking for brief discussion at dev meeting...mainly to see what repo this issue belongs in. At the moment, I do not think any action is necessary, but it would be good to have an open issue to document reading list problems, so if we start to get some user requests we can consider addressing fixes if warranted.

samreid commented 6 years ago

Marking for brief discussion at dev meeting...mainly to see what repo this issue belongs in.

Joist seems to be the most appropriate repo, since it deals with loading the simulation.