search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

selectedTabProperty validValues should only be the supported tabs #822

Closed zepumph closed 2 years ago

zepumph commented 2 years ago

From https://github.com/phetsims/joist/issues/744#issuecomment-1179308610, it would be best if when we created this Property, we only provided it with the validValues that can actually work for this runtime. This makes most sense for PhET-iO. We have the info, we just want to provide the data manually based on support. Tagging @jessegreenberg but I'll do the work.

zepumph commented 2 years ago

Oh wow! That was easier than I thought it would be, we already have a list of supported tabs. Thanks @jessegreenberg for being good at your job. Closing