localeProperty should be part of PreferencesModel

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.

MIT License

8 stars 6 forks source link

localeProperty should be part of PreferencesModel #847

Closed zepumph closed 2 years ago

zepumph commented 2 years ago

From https://github.com/phetsims/joist/issues/840#issuecomment-1227835873, and the work we did in https://github.com/phetsims/joist/issues/743. We shouldn't pull in globals, but instead pass them through the preferencesModel.localizationModel

zepumph commented 2 years ago

@jessegreenberg can you please review.

jessegreenberg commented 2 years ago

This is great, thanks!