Localization is not an i18n string

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.

MIT License

8 stars 6 forks source link

Localization is not an i18n string #848

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

Seems like something to fix before publication!!

https://github.com/phetsims/joist/blob/7012e5db338713a7d26bd247702962f2c1bd4310/js/preferences/PreferencesTabs.ts#L65-L73

zepumph commented 1 year ago

I'll do this. I hit it while reviewing https://github.com/phetsims/joist/issues/838.

zepumph commented 1 year ago

@jessegreenberg please review. Feel free to close.

jessegreenberg commented 1 year ago

Great, thanks! It seems reasonable to make these translatable now.