search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
http://scenerystack.org/
MIT License
9 stars 6 forks source link

support dynamic locale switching in toolbar #850

Closed zepumph closed 2 years ago

zepumph commented 2 years ago

This blocks friction phet-io

zepumph commented 2 years ago

I'll do this. I hit it while reviewing https://github.com/phetsims/joist/issues/838.

zepumph commented 2 years ago

The work here is done, but it isn't currently doing anything because of https://github.com/phetsims/joist/issues/852. @jessegreenberg please review once that work is done.

jessegreenberg commented 2 years ago

Thanks @zepumph, commits to use *StringProperty for Toolbar strings looks good. How we handle i18n for this content is dependent on https://github.com/phetsims/joist/issues/853. Blocked until then. Adding labels to match that issue.

jessegreenberg commented 2 years ago

In #853 we decided that Voicing content should be hidden when switching away from the English locale so contents of the VoicingToolbarItem do not need to support locale switching because those strings are not translatable.

In #852 I asked if it would be clearer for these non-translatable strings to be defined locally instead of nested under the a11y key. If so, that should be done for VoicingToolBarItem as well. This issue can be closed, we will do that there if it is best.