StringProperty local variables should have StringProperty suffix

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.

MIT License

8 stars 6 forks source link

StringProperty local variables should have StringProperty suffix #856

Closed samreid closed 1 year ago

samreid commented 1 year ago

From https://github.com/phetsims/joist/issues/844#issuecomment-1247421486

@zepumph said:

I see 71 usages of String = .*StringProperty;, should these variables be renamed? I kinda don't think it matters.

I would like to rename the left hand side to end in *StringProperty.

samreid commented 1 year ago

I added these in the commits. Wondering if we want a type-aware lint rule that axon Property instances should end in a Property suffix. Separate issue?