search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

Preferences model: move toolbarEnabledProperty to Audio #866

Closed kathy-phet closed 1 year ago

kathy-phet commented 1 year ago

In review, we noticed that toolbarEnabledProperty was classified in the Preferences Model under "visualModel", but is hooked up to a selection under "audioModel". Please move it to the "Audio" part of the Preferences Model in the Studio Tree: friction.general.model.preferencesModel.visualModel.toolbarEnabledProperty

Thanks, K

samreid commented 1 year ago

I moved it to friction.general.model.preferencesModel.audioModel.toolbarEnabledProperty, @arouinfar or @kathy-phet want to review?

arouinfar commented 1 year ago

@samreid thanks, looks good in master.