phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

Preferences Dialog: When only audio is some sound, simplify "Sound" text description #871

Open kathy-phet opened 1 year ago

kathy-phet commented 1 year ago

In Number Play meeting, the "Sound" text description seemed to cause some confusion when there was no UI sound or sonification. Perhaps no only hide the toggle, but also simplify the description so its more general for these case, since "Audio" will be in every sim with a preferences dialog now.

I don't quite know everyone who should weigh in on that.

jessegreenberg commented 1 year ago

@chrisklus instead of disabling user-interface sounds would you be able to disable all sound in package.json by removing

supportsSound: true

in package.json?

Then this tab in Preferences (and the whole dialog) would go away in number-play.

kathy-phet commented 1 year ago

Number Play voices the numbers and has game sounds, so I suspect this won't work.

jessegreenberg commented 1 year ago

OK got it. If the voiced numbers were the only audio we could probably do this but we need supportsSound: true to still have game sounds.

jessegreenberg commented 1 year ago

Here is the control for the case of number-play

image

For the other sims where "UI sound" is disabled, maybe that description still makes sense because what plays are the custom sounds and sonifications. But Number-play also includes some synthesis.

I could imagine a few ways to handle this,

@amanda-phet @kathy-phet over to you for next steps or to bring in others from the sound team.

kathy-phet commented 1 year ago

Related to: https://github.com/phetsims/joist/issues/729

kathy-phet commented 1 year ago

Related to: https://github.com/phetsims/joist/issues/736

amanda-phet commented 1 year ago

Decision 10/20/22 for Number Play: we will put the "count aloud" feature under the Audio tab, so this discussion can be postponed.