Convert joist string usage to dynamic strings

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.

MIT License

8 stars 6 forks source link

Convert joist string usage to dynamic strings #873

Closed jonathanolson closed 1 year ago

zepumph commented 1 year ago

I will work with Agustin on that issue.

zepumph commented 1 year ago

Could I please review this to double check?

zepumph commented 1 year ago

still some todos I'll take a look at

zepumph commented 1 year ago

Review:

I looked through all commits, and stumbled across https://github.com/phetsims/utterance-queue/issues/94
I updated TODOs to point over to https://github.com/phetsims/joist/issues/885.
I looked through all usages of StringUtils.fillIn to see if they could be PatternStringProperty, or some other pattern.
I think that is all, but would you mind reviewing what I've done, and seeing if there is anything else? Thanks @AgustinVallejo.

phet-dev commented 1 year ago

Reopening because there is a TODO marked for this issue.