Replace hasKeyboardHelpContent with "if any simScreen supplies keyboardHelpContent"

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.

MIT License

8 stars 6 forks source link

Replace hasKeyboardHelpContent with "if any simScreen supplies keyboardHelpContent" #876

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

Right now we duplicate a flag on sim and screens, but I think we can just use the presence of an option in each screen to determine if we support keyboard help. Noting and assigning myself. Please @jessegreenberg, let me know if you want to discuss this further.

jessegreenberg commented 1 year ago

Yes, removing the sim option seems like a good thing to do.