search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

Sim voicing off silences voicing in the preferences dialog #887

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

I'm not sure if this is by design, but it seems buggy to me. I'd like to discuss with @jessegreenberg about this and try to fix it if it is indeed a bug.

zepumph commented 1 year ago

To reproduce:

  1. turn voicing on
  2. turn sim voicing off in the toolbar
  3. go to the preferences dialog and toggle audio features or voicing, I hear nothing.
zepumph commented 1 year ago

@jessegreenberg mentioned that ideally the voicing panel section would not be categorized as "sim", but at some point we cut a corner and preferences are considered sim voicing. So this is expected behavior.

https://github.com/phetsims/joist/blob/9f8b9bc5922cf974d0dcd633e405f4427a66ff74/js/preferences/VoicingPanelSection.ts#L295-L298

Closing