search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
http://scenerystack.org/
MIT License
9 stars 6 forks source link

sh locale listed for Beer's Law Lab without locale name #904

Closed stemilymill closed 1 year ago

stemilymill commented 1 year ago

https://github.com/phetsims/qa/issues/889

While testing dynamic locale switching for Beer's Law Lab, I noticed a locale labelled only as sh, which is a deprecated code for serbo-croatian. Beer's Law Lab is the only sim with translations in this locale. On the published sim page the serbo-croatian translation is also listed as sh.

The initial reason I brought this up was the lack of a name for the locale, but after looking into what sh was the code for another concern is that serbo-croatian is generally not currently considered to be one language.

samreid commented 1 year ago

@zepumph and I observed these locales have the locale code as the translated name:

  fu: {
    name: 'Friulian',
    localizedName: 'fu',
    direction: 'ltr'
  },

// ...
  ry: {
    name: 'Rusyn',
    localizedName: 'ry',
    direction: 'ltr'
  },

// ...

  sh: {
    name: 'Serbo-Croatian',
    localizedName: 'sh',
    direction: 'ltr'
  },

@jbphet How would you like to proceed?

samreid commented 1 year ago

We also observed that we currently have 0 ry translations, 0 fu translations, and 1 sh translation for BLL+ joist.

samreid commented 1 year ago

@jbphet @liammulh and I discussed this today. We agreed that sh only has translations for us in BLL + joist, and we think it seems to be a rarely used language. @jbphet and @liammulh discussed that it may be best in the long run to remove the sh locale, but it would take a long time to update everything and would require removing published sims. So instead they recommend changing the localizedName, then requesting @mattpen if some change is needed for the sim page.

samreid commented 1 year ago

We also agreed to remove ry and fu.

samreid commented 1 year ago

BLL was just a dev test, so this doesn't need to be cherry-picked. Closing.

jonathanolson commented 1 year ago

There are translations in the production sim database (that yotta is pulling from) that have the locales 'fu' and 'sh'. Removing those locales broke yotta (now that I pulled these changes).

So, can we either (a) revert the localeInfo changes, or (b) if they aren't used, remove the relevant translations?

samreid commented 1 year ago

@zepumph and @jonathanolson and I discussed this today. We agreed to add back in the fu and ry so that yotta will be usable.