search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

Tab highlight floats when Title height shrinks #917

Closed chrisklus closed 1 year ago

chrisklus commented 1 year ago

@zepumph and I noticed this when working on https://github.com/phetsims/number-play/issues/216:

image

I have also noticed this in real cases (changing languages instead of using the dynamic locale) to a less extreme.

chrisklus commented 1 year ago

Looks like underlineNode in PreferencesTab will be the place. I'll reach out to pair with @jessegreenberg on this early next week (or look more in depth on my own and then pass back for review)

Here is real example on master with es_ES:

image
chrisklus commented 1 year ago

Tagging https://github.com/phetsims/qa/issues/929

chrisklus commented 1 year ago

From 4/11 standup with @zepumph and @Nancy-Salpepi:

We think this is nice to have but not blocking.

chrisklus commented 1 year ago

@zepumph and I addressed this in the above commit and tested various lengths of strings, as well as with alt input. We think this is a nice improvement. We think this is good to close.