phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

Dynamic locale changes causes Dialogs to change scale and size #918

Open zepumph opened 1 year ago

zepumph commented 1 year ago

Reported in https://github.com/phetsims/number-play/issues/215, and likely something to handle with the preferences overhaul, we saw that maxWidth on individual UI components/text wasn't sufficient, because if ever there is a "first locale" string less than the maxWidth, and then you change to another locale where the string is larger, the Dialog will change while pressing on the new locale. This makes usability a bit quirky. I don't know how to solve this but in the PreferencesDialog itself, with a minwidth on the content, and then maxWidths with individual panels. Likely we should look into this for other dialogs too, but you can only change the locale via this dialog.