Closed samreid closed 1 year ago
@catherinecarter commented:
I don't think the error dialog should block publication. [for CAV 1.0]
@samreid said:
... The listed authors for QueryParametersWarningDialog.ts are @chrisklus and @pixelzoom. Can you please comment on questions like: ...
QueryParametersWarningDialog was intentionally barebones/simple. From the design issue:
@arouinfar in https://github.com/phetsims/joist/issues/593#issuecomment-578907663:
I believe the conclusion in PhET-iO meeting was to keep the dialog simple and shift some responsibility to the user.
@amanda-phet in https://github.com/phetsims/joist/issues/593#issuecomment-578917716:
If the decision is to keep the dialog simple, this certainly works. It's not the most user-friendly, but I think that isn't necessarily the goal right now. My understanding is that we want to create a more robust solution later and will put more effort in to making it user friendly at that time. If that is all correct, then this looks like a fine solution for now.
We intentionally went "simple" because there is a recognized need for a QueryStringMachine 2.0. Rather than putting effort into QueryParametersWarningDialog, PhET should be advancing QueryStringMachine 2.0. So I recommend that we do nothing and close this issue.
The recommendation in the preceding comment sounds good to me, @catherinecarter what do you think?
Sure - sounds like this has come up in the past, and the solution is to keep as is and put effort into other, more valuable, items. Thanks for weighing in, @pixelzoom, and for providing more information about the history of this discussion. Ok with me to close.
From https://github.com/phetsims/center-and-variability/issues/148#issuecomment-1545878197, @catherinecarter said:
The listed authors for QueryParametersWarningDialog.ts are @chrisklus and @pixelzoom. Can you please comment on questions like: