search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

Non-screen navbar buttons have gotten smaller. #925

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

The Home screen button in master (and recent production deploys and RCs) is significantly smaller than in past production deploys. Is this an intentional change or a regression?

For example:

master:

screenshot_2521

production 1.1.0:

screenshot_2520

This problem is also present in the current Density RC https://github.com/phetsims/qa/issues/942 (@jonathanolson FYI), and the Geometric Optics RCs https://github.com/phetsims/qa/issues/944, https://github.com/phetsims/qa/issues/945.

It's also present in recent production deploys, like My Solar System 1.2.0.

pixelzoom commented 1 year ago

Actually, it looks like all of the non-screen buttons have gotton smaller.

Maybe adding the Preferences button causes this? That's a difference between the screenshots above.

pixelzoom commented 1 year ago

@kathy-phet replied in Slack:

We made them smaller. It was a design change from an issue you made last fall. And yes, from adding preferences sound and keyboard with phetio logo. It was to give more space. We made everything including the logo a bit smaller. But not the screens

Closing.