Is it OK to have irrelevant info in the keyboard dialog after PhET-iO customizations?

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.

MIT License

8 stars 6 forks source link

Is it OK to have irrelevant info in the keyboard dialog after PhET-iO customizations? #936

Open Nancy-Salpepi opened 10 months ago

Nancy-Salpepi commented 10 months ago

When testing https://github.com/phetsims/qa/issues/973, I noticed that removing the Play/Pause button or the Reset All button in studio also disables the corresponding keyboard shortcut (alt/opt + K and alt/opt + R). However, those shortcuts will still be listed in the dialog. Is it OK to still have that information there even though it is no longer relevant?

arouinfar commented 10 months ago

Thanks for opening this @Nancy-Salpepi. I've added this to the PhET-iO Meeting agenda to make sure we're on the same page.

@jbphet this does not block Greenhouse Effect.

pixelzoom commented 10 months ago

Trying to automatically show/hide parts of the keyboard help based on which parts of the UI are visible is not a problem that I think we should try to solve. It will introduce big complications for little-to-no benefit. It would be better to instrument visibleProperty for sections of keyboard help, and allow the instructional designer to hide irrelevant sections – if that’s important to them.