search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

PreferencesModel doesn't respect query parameters for defaults #942

Closed zepumph closed 7 months ago

zepumph commented 7 months ago

In https://github.com/phetsims/chipper/issues/1031 we made simFeatures in package.json be the default for query parameters to have a consistent way to provide a committed default + query parameter opt-in/out support for simFeatures. Looks like ?supportsInteractiveDescription is awesome, but in PreferencesModel, we call on simFeatures instead of the query parameter.

We want to help apply that pattern to ?regionAndCulture now, and so we want to make sure we do it right.

zepumph commented 7 months ago

Ahh goodness, it was just a variable name problem. Sorry!

https://github.com/phetsims/joist/blob/a8a60e43611ef95c0f28f8946c3db8315bcae496/js/preferences/PreferencesModel.ts#L198-L202