search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
http://scenerystack.org/
MIT License
9 stars 6 forks source link

Difficult to find RegionAndCulture ComboBox in preferences #945

Closed marlitas closed 10 months ago

marlitas commented 11 months ago

While meeting with @pixelzoom he mentioned that he had a difficult time finding the ComboBox control for "Region and Culture" because it looked like the ComboBox label was actually the language selection label. He kept clicking a language thinking that was actually changing the region and culture portrayals. It took him several minutes to finally notice the ComboBox in the far right:

image

We both acknowledged that there is a lot of preferences design work that needs to be done to find a long term solution for this, but thought that an appropriate short term solution would be to add a label and description for the language selection so that it feels separated from the "Region and Culture" selection.

@amanda-phet, I felt this was something the two of us could discuss and find a good strategy moving forward. It would be easy to cherry pick this change into sims that are already in RC as well.

amanda-phet commented 11 months ago

Yes! I remember thinking (if I didn't say it) that the locale selection box could use a label and thought it was strange it didn't have one. I just assumed that we don't have enough space to fit everything, but if we can label that I agree that it would be really beneficial.

marlitas commented 11 months ago

Okay perfect. What would you like the label and description to be?

amanda-phet commented 11 months ago

Just 'Locale' for the label seems fine to me. I wouldn't add a description.

marlitas commented 11 months ago

@amanda-phet and I discussed in Slack that we will reuse the label and description that were being provided to the PDOM for the localePanel. That has been committed above and is now ready to cherry-pick for https://github.com/phetsims/qa/issues/1014 and https://github.com/phetsims/qa/issues/1016

marlitas commented 11 months ago

@Luisav1 will also cherry-pick into energy-skate-park

marlitas commented 10 months ago

I believe this has been cherry-picked for all active RCs that would need this change. Can be closed by QA once verified.

Nancy-Salpepi commented 10 months ago

For Number Line: Integers 1.2.0-rc.4, there is now a 'Languages' label and description.

Nancy-Salpepi commented 10 months ago

ESP doesn't have dynamic locale, so there was nothing to check for https://github.com/phetsims/qa/issues/1022.

Nancy-Salpepi commented 10 months ago

For NL: Operations rc.2, the "Languages" title and description have been added to the Localization tab (noting that this sim doesn't have a Region and Culture combobox).

marlitas commented 10 months ago

I believe all related cherry picks to this issue are now complete. Closing!