phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

localeProperty validValues changed #946

Closed zepumph closed 6 months ago

zepumph commented 6 months ago

In some recent change, the localeProperty's validValues changed in some sims removing a few supported locales, and it is failing CT for PhET-iO migration.

ph-scale main is missing zu and sn compared to 1.6 acid-base-solutions main is missing mt and ps compared to 1.3 gravity-and-orbits main is missing zu compared to 1.6

I want to link https://github.com/phetsims/gravity-and-orbits/issues/485 with this issue because both started happening over the weekend-ish and I can't find a cause (yet). Tagging @samreid so he knows too. Here is what a CT error looks like:

Assertion failed: MigrationReport problem: propertyValidValueNoLongerSupported

{
"clientMessages": [],
"stateSchemaIncompatible": [],
"initialStatesAreIncompatible": [],
"propertyValidValueNoLongerSupported": [
{
"phetioID": "phScaleBasics.general.model.localeProperty",
"missingValue": "sn"
},
{
"phetioID": "phScaleBasics.general.model.localeProperty",
"missingValue": "zu"
}
],
"switchedFromInvalidValueToNewDefault": [],
"phetioIDNotInNewAPI": [],
"notStatefulAnymore": [],
"incompletePhetioElementRenames": [],
"incompletePhetioElementDeletes": [],
"processedNothing": [],
"newNeededIOTypes": {},
"relatedIOTypesForValueRenameHaveUnexpectedSchemas": [],
"missingStringPhetioElements": []
}
zepumph commented 6 months ago

Looks like this was a regression caused by https://github.com/phetsims/phet-io-wrappers/commit/ef678f62844b04592bc07caa0488e4f6676d1d65. Sorry!