search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

Preferences Menu Layout - On/Off Swithces too far from name/label. #969

Open terracoda opened 1 month ago

terracoda commented 1 month ago

Something has moved the toggle switches in the Preferences Menu too far from their actual names.

Here's a screenshot of GFLB from PhET Bookmarks Screenshot 2024-05-27 at 13 04 14

Here's a screenshot of the published sim, Screenshot 2024-05-27 at 13 07 54

I think the toggle switched need to above the paragraph that's describing the switch's function, or right next the name. Currently, on Main, the Voicing toggle switch is right next the the Sound toggle switch which is really confusing.

terracoda commented 1 month ago

@jessegreenberg, tagging you because, I am not sure who to assign to this issue? Not sure when/how the layout changed.

This issue is appearing on all sims with Voicing on Main, and not in published sims.

jessegreenberg commented 4 weeks ago

Thanks @terracoda, I will take a look.

jessegreenberg commented 4 weeks ago

I think this was introduced from https://github.com/phetsims/joist/commit/af68dfb506769e882b56df925f7f994097be7a8a for https://github.com/phetsims/number-line-integers/issues/118. It looks better if I remove the minContentWidth. @marlitas or @jonathanolson is it OK if we remove that value and do you know why it was added for NLI?

jessegreenberg commented 3 weeks ago

Maybe it is because some controls are nicely aligned like this:

image