phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
http://scenerystack.org/
MIT License
9 stars 6 forks source link

Chemical formulas in Dari rendering incorrectly (backwards?) in Build a Molecule #973

Closed JacquiHayes closed 4 months ago

JacquiHayes commented 5 months ago

In the Build a Molecule simulations, the chemical formulas are shown incorrectly.

Here is an example from a similar language, Pashto, where they are shown correctly: Screenshot 2024-06-27 at 2 16 12 PM

Here is a screenshot of how they are shown in Dari, which is incorrect: Screenshot 2024-06-27 at 2 13 46 PM

zepumph commented 4 months ago

Noting https://github.com/phetsims/build-a-molecule/issues/220

jonathanolson commented 4 months ago

Looks like this is working nicely in main. My patch in 2022 (https://github.com/phetsims/chipper/issues/1355) solves this issue. @kathy-phet should we MR this?

kathy-phet commented 4 months ago

Yes, please MR

—— Kathy Perkins Ph.D. Director, PhET Interactive Simulations

(Sent from my iPhone)


From: Jonathan Olson @.> Sent: Thursday, June 27, 2024 11:40:22 AM To: phetsims/joist @.> Cc: Kathy Perkins @.>; Assign @.> Subject: Re: [phetsims/joist] Chemical formulas in Dari rendering incorrectly (backwards?) in Build a Molecule (Issue #973)

[External email - use caution]

Assigned #973https://github.com/phetsims/joist/issues/973 to @kathy-phethttps://github.com/kathy-phet.

— Reply to this email directly, view it on GitHubhttps://github.com/phetsims/joist/issues/973#event-13321040410, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABG4KZHLBSN7CC4L5AYFWB3ZJRFANAVCNFSM6AAAAABJ7ZXIBOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGMZDCMBUGA2DCMA. You are receiving this because you were assigned.Message ID: @.***>

jonathanolson commented 4 months ago

QA test in https://github.com/phetsims/qa/issues/1113.

jonathanolson commented 4 months ago

Most of this work is handled. Any remaining work will be handled in https://github.com/phetsims/build-a-molecule/issues/220.