search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

Delete unused translations of region and culture strings #975

Open jbphet opened 2 days ago

jbphet commented 2 days ago

Issue https://github.com/phetsims/joist/issues/958 contains a list of steps that was needed to migrate from one approach for handling region and culture selections to a new one that was in common code. It looks like one step was missed - removing the strings that were translated while the older approach was in place. I've looked through the translations, and it looks like only energy-skate-park and soccer-common have these strings. They should be removed so that they don't cause confusion in the future.

jbphet commented 2 days ago

Before doing this, we would need to make sure that the affected sims have been re-published with the updated code and are no longer referencing their own sim-specific versions of these strings.