phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

a11y strings used in visual text; not translatable! #976

Open zepumph opened 3 days ago

zepumph commented 3 days ago

@DianaTavares and I found over in https://github.com/phetsims/babel/issues/24 that we have been using a couple of string under a11y for visual text, and published those sims that way. For example, arithmetic 1.2

https://github.com/phetsims/joist/blob/a8e354f11185d34a0832c003d96eb1f6987395af/js/preferences/LocalizationPreferencesPanel.ts#L73-L77

I have not more research here, but I'll mark for dev prioritization.

zepumph commented 3 days ago

Perhaps effecting all sims since 12/23/24:

https://github.com/phetsims/joist/commit/a38b1d5cc4b00ffa5a996b872554df259e3e1380