search

phetsims / keplers-laws

"Kepler's Laws" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 1 forks source link

Stopwatch timer is not scaled equal to the sim #175

Closed AgustinVallejo closed 1 year ago

AgustinVallejo commented 1 year ago

Noticed during https://github.com/phetsims/qa/issues/984, when switching between slow, normal, fast, the readout of the stopwatch is always the same.

KatieWoe commented 1 year ago

I noticed this as well. While the speed options seemed fixed on main, I did see that if the sim is paused and stepped forward, the stopwatch does not count up. Reopening since this seems like the same issue, but if you want a new one, let me know.

AgustinVallejo commented 1 year ago

Oh thanks! Didn't notice that. Seems fine on this issue.

KatieWoe commented 1 year ago

One more point about the stopwatch. If it is still going when you uncheck it's box, then bring it back it will still be at the reading it was before. Is this the desired behavior?

AgustinVallejo commented 1 year ago

I think it should be done now. Could you please review and close if done? Thanks!

KatieWoe commented 1 year ago

Looks good! Normally these are left open to verify in the next rc, and closed then. Which would you prefer?

Nancy-Salpepi commented 1 year ago

Looks good in rc.2!