phetsims / keplers-laws

"Kepler's Laws" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 1 forks source link

Graph arrow doesn't appear in screenshot #180

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air M1 chip

Operating System 13.5.2

Browser Safari/Chrome (also Win10 + FF)

Problem description For https://github.com/phetsims/qa/issues/984, on the Third Law Screen if I take a screenshot from the PhET Menu, the arrow in the graph doesn't appear. The pink dot does.

Steps to reproduce

  1. On the Third Law Screen, move the body until a line with an arrow appears in the graph
  2. Take a screenshot from the PhET Menu

Visuals In the sim:

Screenshot 2023-09-26 at 2 32 32 PM

In the screenshot:

Screenshot 2023-09-26 at 2 32 21 PM
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Kepler's Laws‬ URL: https://phet-dev.colorado.edu/html/keplers-laws/1.1.0-rc.1/phet/keplers-laws_all_phet.html Version: 1.1.0-rc.1 2023-09-18 17:02:56 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36 Language: en-US Window: 1345x718 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
AgustinVallejo commented 1 year ago

Got inspired by https://github.com/phetsims/my-solar-system/issues/52 to fix this. Please review!

Nancy-Salpepi commented 1 year ago

The arrow is now in the screenshot, but the entire panel moves now.

https://github.com/phetsims/keplers-laws/assets/87318828/b0164916-d6db-4d61-9fc5-2b489120339d

AgustinVallejo commented 1 year ago

Improved the padding for the contents of the graph. Please review @Nancy-Salpepi, and thanks!

Nancy-Salpepi commented 1 year ago

Looks good 🙂. Keeping open for the next rc.

KatieWoe commented 1 year ago

Looks good in rc.2