search

phetsims / keplers-laws

"Kepler's Laws" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 1 forks source link

Swept Area Colors are different in launched sim #239

Closed Nancy-Salpepi closed 7 months ago

Nancy-Salpepi commented 8 months ago

Test device MacBook Air M1 chip

Operating System 14.1.2

Browser Safari 17.1.2

Problem description For https://github.com/phetsims/qa/issues/1023, on the Second Law Screen in the State wrapper: The colors in the downstream sim don't match those in the upstream sim. Pressing play results in the colors changing to match.

Steps to reproduce

  1. Set state rate = 0 in the State wrapper
  2. Press Play and then after an area has been filled, press Pause
  3. Press Set state now --> colors don't match
  4. Press Play --> colors match

Visuals

Screenshot 2024-01-17 at 2 47 28 PM
pixelzoom commented 8 months ago

@AgustinVallejo Let me know if you need help with this.

AgustinVallejo commented 7 months ago

More concerningly, when reproducing this by setting state after every orbital division step, I got the sim to this abomination: image

AgustinVallejo commented 7 months ago

Or this: image

AgustinVallejo commented 7 months ago

The color issue has been hopefully resolved. The shape mismatch thing is a little bit more complicated and I'll be addressing it in a separate issue: https://github.com/phetsims/keplers-laws/issues/248.

Please review the bug reported in the original comment.

Nancy-Salpepi commented 7 months ago

The color issue has been solved. Closing.