search

phetsims / keplers-laws

"Kepler's Laws" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 1 forks source link

isActiveProperty should not be featured #254

Closed Nancy-Salpepi closed 8 months ago

Nancy-Salpepi commented 9 months ago

Test device MacBook Air M1 chip

Operating System 14.3

Browser Safari 17.3

Problem description For https://github.com/phetsims/qa/issues/1034, please unfeature the isActiveProperty for both bodies on all screens. I confirmed this with @arouinfar over slack:

Oh, good find. I think isActiveProperty is likely a necessary for the implementation, but it doesn’t make sense to feature it in the context of Kepler’s Laws, which always has 2 active bodies that cannot crash or escape.

Screenshot 2024-02-06 at 2 15 38 PM
AgustinVallejo commented 9 months ago

Assigning back for review, and then cherry pick

Nancy-Salpepi commented 9 months ago

Looks good on Main.

Nancy-Salpepi commented 8 months ago

Looks good in rc.2 Closing!