search

phetsims / keplers-laws

"Kepler's Laws" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 1 forks source link

sweptAreaProperty for orbitalArea3 is initially incorrect #261

Closed Nancy-Salpepi closed 8 months ago

Nancy-Salpepi commented 8 months ago

Test device MacBook Air M1 chip

Operating System 14.3

Browser Safari and chrome

Problem description For https://github.com/phetsims/qa/issues/1034, in Studio on the Second Law screen the orbitalArea3.sweptAreaProperty states that the current value = 0 even though it shows a swept area:

Screenshot 2024-02-08 at 12 35 06 PM

If I press Reset All, it then shows the correct value of 1.66......

Screenshot 2024-02-08 at 12 35 18 PM

I didn't see this with other areas.

Steps to Reproduce

  1. In studio, go to keplersLaws.secondLawScreen.model.orbitalAreas.orbitalArea3.sweptAreaProperty and note the value
  2. Press the Reset All button
AgustinVallejo commented 8 months ago

Above commits address this area problem, please review and mark for cherry picking if OK

Nancy-Salpepi commented 8 months ago

Looks fixed on main

Nancy-Salpepi commented 8 months ago

Looks good in rc.2 Closing!