Rendering order and location of cueing arrows different than published

phetsims / keplers-laws

"Kepler's Laws" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

1 stars 1 forks source link

Rendering order and location of cueing arrows different than published #263

Closed Nancy-Salpepi closed 7 months ago

Nancy-Salpepi commented 7 months ago

Test device MacBook Air M1 chip and Chromebook

Operating System macOS 14.3

Browser Safari and Chrome

Problem description For https://github.com/phetsims/qa/issues/1034, I see 2 differences between 1.2.0-rc.1 and published: the grid lines seem to now be in front of the semiaxes. Also the cueing arrows are further from the planet than in published.

Visuals rc:

published:

AgustinVallejo commented 7 months ago

Fixed rendering order and cueing arrows. Please review and mark for cherry picking :)

Nancy-Salpepi commented 7 months ago

Cueing arrows look good on main

Nancy-Salpepi commented 7 months ago

Now that you made the rendering order change I can see that it wasn't actually the order that was different....it looks like the grid lines where thinner in published. I think the current look on main looks OK, but wanted to double check with @AgustinVallejo and @arouinfar.

RC:

Published:

Main:

AgustinVallejo commented 7 months ago

Reverting the grid change. According to @arouinfar, grid should always be on top.

Nancy-Salpepi commented 7 months ago

Change has been reverted. Cueing arrows ready to cherry pick.

Nancy-Salpepi commented 7 months ago

Cueing arrows look good.