Open pixelzoom opened 1 year ago
@jonathanolson added paper.js as a dependency for all sims for "Handling quadratic/cubic intersection with bezier clipping". There was no associated GitHub issue, but for example see https://github.com/phetsims/graphing-quadratics/commit/d6b9aa988b9a91a96d6b814463bedafa0b7f411a.
This increased the size of all sims. For graphing-quadratics, it's ~10% increase, see below.
Is this expected and acceptable? It seems like a steep price to pay for this one feature.
Before paper.js:
-rw-r--r-- 1 cmalley staff 22782949 Jul 12 11:20 graphing-quadratics_all_phet_debug.html -rw-r--r-- 1 cmalley staff 2073566 Jul 12 11:20 graphing-quadratics_en_phet.html
After paper.js
-rw-r--r-- 1 cmalley staff 23185232 Jul 12 12:58 graphing-quadratics_all_phet_debug.html -rw-r--r-- 1 cmalley staff 2286405 Jul 12 12:58 graphing-quadratics_en_phet.html
It should be possible to port that section of the code (or reimplement from the papers/literature), I'll look into that.
@jonathanolson added paper.js as a dependency for all sims for "Handling quadratic/cubic intersection with bezier clipping". There was no associated GitHub issue, but for example see https://github.com/phetsims/graphing-quadratics/commit/d6b9aa988b9a91a96d6b814463bedafa0b7f411a.
This increased the size of all sims. For graphing-quadratics, it's ~10% increase, see below.
Is this expected and acceptable? It seems like a steep price to pay for this one feature.
Before paper.js:
After paper.js