search

phetsims / kite

A library for creating, manipulating and displaying 2D shapes in JavaScript.
MIT License
12 stars 6 forks source link

regression tests are broken #63

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

kite @733028991124bcea81c36b315f00e18453ba3d7b

http://localhost/~cmalley/GitHub/kite/tests/qunit/compiled-unit-tests.html

0 assertions of 35 passed, 35 failed.

screenshot_18

samreid commented 7 years ago

It looks like you are running the compiled unit tests. Did you build kite first?

Here's the requirejs unit tests: http://localhost/kite/tests/qunit/unit-tests.html

samreid commented 7 years ago

Build is failing, I'm not sure why:

Running "requirejs:development" (requirejs) task

Error: TypeError: Cannot read property 'chipper' of undefined In module tree: AXON/main AXON/Property ifphetio

at Object.load (eval at <anonymous> (/Users/samreid/github/kite/node_modules/requirejs/bin/r.js:28057:38), <anonymous>:31:25)

Warning: Task "requirejs:development" failed. Use --force to continue.

Aborted due to warnings.

samreid commented 7 years ago

Fixed build above, now I'm seeing tests pass for built and requirejs modes. @pixelzoom can you review?

pixelzoom commented 7 years ago

I navigated to http://localhost/~cmalley/GitHub/kite/, was presented with a webpage, and (silly me) thought that pressing the "Test" button would be useful.

Kite now building, tests passing.

Assigning to @jonathanolson to put some useful information in kite/tests/README.md.

jonathanolson commented 7 years ago

Added notes that compiled tests require building first, and updated build instructions for 'grunt build-js'