use self for closure variable

phetsims / kite

A library for creating, manipulating and displaying 2D shapes in JavaScript.

MIT License

13 stars 6 forks source link

use self for closure variable #64

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

After discussion at 9/15/16 developer meeting, PhET has standardized on the name used for the closure variable whose value is this:

var self = this;

Please update this repository accordingly. Looks like only 4 occurrences, so should be pretty quick. I'd do it myself, but the regression tests are currently in a broken state (https://github.com/phetsims/kite/issues/63).

samreid commented 8 years ago

Fixed above and unit tests are passing, and grunt is passing.

@pixelzoom do you want to review?