search

phetsims / kite

A library for creating, manipulating and displaying 2D shapes in JavaScript.
MIT License
12 stars 6 forks source link

Circles and ellipses not automatically closed #70

Closed jonathanolson closed 7 years ago

jonathanolson commented 7 years ago

e.g. new Shape().circle( ... ).circle( ... ) would have a line segment between the two circles.

I'll plan to fix this up to be more like .rect() so that it closes.

pixelzoom commented 7 years ago

Ditto for ellipse, ellipticalArcToRelative and possibly others.

Also... Shape.circle (static) returns a closed circle in one case, unclosed in the other.

jonathanolson commented 7 years ago

Should be fixed. @pixelzoom can you confirm?

I did not see any elliptical cases that would break when searching, and I think it's unlikely this would actively break anything used.

pixelzoom commented 7 years ago

Inspected commit, verified in context of equality-explorer (see above commit). Closing.