search

phetsims / make-a-ten

"Making Tens" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

"Paper" & "total" layering is not the same across screens #266

Closed phet-steele closed 7 years ago

phet-steele commented 7 years ago

@amanda-phet the layering of the paper on the first screen puts it above the total:

screen shot 2017-02-01 at 10 43 18 am

The layering on the 2nd and 3rd screens puts the paper under the total:

screen shot 2017-02-01 at 10 43 27 am

Should these be consistent? Which is preferred?

For phetsims/tasks/issues/767.

amanda-phet commented 7 years ago

Hm, I agree that these should be consistent, but I recall @bethstade having reasons for them layering differently. I would lean toward laying the paper over the text in all screens (including the game screen).

bethstade commented 7 years ago

I agree. Looks like paper should go on top. Just a reminder, I am out to the country and email will be inconsistent until after Feb. 14th.

----- Original Message -----From: Amanda McGarry notifications@github.comTo: phetsims/make-a-ten make-a-ten@noreply.github.comCc: bethstade stadee@colorado.edu, Mention mention@noreply.github.comSent: Wed, 01 Feb 2017 18:18:18 -0000 (UTC)Subject: Re: [phetsims/make-a-ten] "Paper" & "total" layering is not the same across screens (#266)

Hm, I agree that these should be consistent, but I recall @bethstade having reasons for them layering differently. I would lean toward laying the paper over the text in all screens (including the game screen). —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

amanda-phet commented 7 years ago

Let's change the logic then, so that paper is layered above text. Thanks for commenting from London, @bethstade !

jonathanolson commented 7 years ago

@amanda-phet, how should it layer with the other things (edit buttons and keypad on the adding screen, "next" button on the game)?

amanda-phet commented 7 years ago

Keypad should be on top (always). Numbers should be on top of edit, reset all, and next buttons.

jonathanolson commented 7 years ago

Made the requested changes. Also the numbers were over "Hide Total" in the first screen (which seemed inconsistent), so I moved that behind the numbers also.

Can you review?

amanda-phet commented 7 years ago

Looks good on the first two screens, but to be consistent the paper numbers should be layered over the text numbers and next button on the game screen.

jonathanolson commented 7 years ago

Sorry about that, definitely forgot about the formula on the game screen. Should be fixed.

amanda-phet commented 7 years ago

It is working for the formula, but still not the next button.

screen shot 2017-02-03 at 12 11 57 pm screen shot 2017-02-03 at 12 12 03 pm

I think we decided it would layer over any button (edit, reset all, and next).

jonathanolson commented 7 years ago

Ok, should be fixed.

amanda-phet commented 7 years ago

Looks great, thanks.